Exercise editor: support updates #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's true :-D It would be nice to make it more usable, but only if we have time for that, since it is only visible to a few admins.
Yeah.. I added it only because I did not have time for a proper solution :) So I still think, it makes sense to put all settings into another table. Let's keep it in mind, but postpone for a while |
|
okay, then this should be ready to merge.. or should I add some CSS today? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #70
Notes
Questions
ExerciseSettingswith key and value columns doesn't appear to be needed since we have theonSubmitMsgandcanAddDeleteGeomcolumns (added by you), as well as thecanEditPropertiescolumn (added in this pull).